fix(remix): Fix issues caused by modifying duplex on Request - #3645
Merged
Conversation
🦋 Changeset detectedLatest commit: c9e1f36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Jul 1, 2024
dimkl
left a comment
dimkl
left a comment
Contributor
There was a problem hiding this comment.
❓ Could we add a test for this?
octoper
force-pushed
the
vaggelis/fix.remix-duplex-issue
branch
from
July 1, 2024 12:12
7f34119 to
c9e1f36
Compare
Contributor
Author
|
@dimkl No easy way to add tests for it as we don't have the infra to support it yet, we will need to check in every runtime and provider (Vercel, Cloudflare etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that was introduced by #3495, where the
duplexproperty was already defined and couldn't not be modified.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change